fix depends in tf_static_publisher #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peci1
requested changes
Apr 22, 2025
Member
peci1
left a comment
peci1
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have one comment which needs to be resolved.
Also, consider if this package should be a part of the ROS One repo as it has never been released (it is ignored in the release repos).
Contributor
Author
Oh, I didn't notice that. Thank you for your comment. |
Member
|
@knorth55 just FYI, camera_throttle has also not been released. It compiles on Noetic, but I don't think anybody has used it in the last few years (last time, we used it for SubT challenge in '21 on Melodic). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
std_srvsfor missing dependencies.this is for ros-one release.
related: ubi-agni/ros-builder-action#48