-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(tesseract): Basic pre-aggregations support #9434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9434 +/- ##
==========================================
- Coverage 84.09% 80.38% -3.72%
==========================================
Files 230 395 +165
Lines 84377 97932 +13555
Branches 0 2278 +2278
==========================================
+ Hits 70959 78723 +7764
- Misses 13418 18901 +5483
- Partials 0 308 +308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
be6e357
to
ccf4c02
Compare
2d7ac7e
to
37e2479
Compare
ccf4c02
to
09309d0
Compare
995c326
to
335c2ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is great!
rust/cubesqlplanner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/optimizer.rs
Outdated
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/optimizer.rs
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/planner/sql_evaluator/collectors/cube_names_collector.rs
Outdated
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/planner/sql_evaluator/symbols/dimension_symbol.rs
Outdated
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/planner/sql_evaluator/symbols/dimension_symbol.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is great! However there are some places need fixing
a171be9
to
34c7040
Compare
Check List