Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(tesseract): Basic pre-aggregations support #9434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tesseract): Basic pre-aggregations support #9434
Changes from all commits
dd4cb55
1257056
33220df
2f77221
9db6bba
1e0deb1
2c688c6
3f92ac1
0b93d8d
6b1e52b
a46541a
50bf6f8
a3b71aa
88e68a4
96b5814
3715135
34c7040
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 295 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L294-L295
Check warning on line 484 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L484
Check warning on line 661 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L660-L661
Check warning on line 663 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L663
Check warning on line 669 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L667-L669
Check warning on line 672 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L671-L672
Check warning on line 677 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L676-L677
Check warning on line 686 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L685-L686
Check warning on line 740 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L740
Check warning on line 744 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L742-L744
Check warning on line 746 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L746
Check warning on line 753 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L751-L753
Check warning on line 756 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L755-L756
Check warning on line 760 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L760
Check warning on line 779 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L779
Check warning on line 783 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L781-L783
Check warning on line 785 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L785
Check warning on line 790 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L789-L790
Check warning on line 814 in packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
packages/cubejs-schema-compiler/src/adapter/BaseQuery.js#L814
Check warning on line 786 in packages/cubejs-schema-compiler/src/adapter/PreAggregations.js
packages/cubejs-schema-compiler/src/adapter/PreAggregations.js#L786
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of
useNativeSqlPlanner
this will always be undefined.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. From this.query.findPreAggregationForQueryRust() code
Yeah, I know it’s not very elegant, but it’s pretty much the only fast way to splice the logic together until the whole PreAggregation part moves into Tesseract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not return it instead of setting? Thus you can keep the logic similar and clean.
Check warning on line 875 in packages/cubejs-schema-compiler/src/adapter/PreAggregations.js
packages/cubejs-schema-compiler/src/adapter/PreAggregations.js#L874-L875
Check warning on line 878 in packages/cubejs-schema-compiler/src/adapter/PreAggregations.js
packages/cubejs-schema-compiler/src/adapter/PreAggregations.js#L877-L878
Check warning on line 883 in packages/cubejs-schema-compiler/src/adapter/PreAggregations.js
packages/cubejs-schema-compiler/src/adapter/PreAggregations.js#L880-L883
Check warning on line 888 in packages/cubejs-schema-compiler/src/adapter/PreAggregations.js
packages/cubejs-schema-compiler/src/adapter/PreAggregations.js#L888