Skip to content

[Dart] Full test coverage & CI enforcement - #699

Open
Fried-man wants to merge 5 commits into
cucumber:mainfrom
Fried-man:test/dart-maximum-coverage
Open

[Dart] Full test coverage & CI enforcement#699
Fried-man wants to merge 5 commits into
cucumber:mainfrom
Fried-man:test/dart-maximum-coverage

Conversation

@Fried-man

@Fried-man Fried-man commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

🤔 What's changed?

The dart solution now has full line coverage via unit test by:

  • excluding generated files from coverage reporting
  • refactoring private methods to be public so they are testable
  • adding more tests

Also, the dart CI now enforces full line coverage.

⚡️ What's your motivation?

Outside of best practices, the low line coverage was brought up in this issue.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

N/A

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

- Updated `generateMessages` to utilize a new `generateMessagesWithParser` function for improved parsing.
- Introduced `GherkinDocumentParser` type for better type safety.
- Renamed `_pickleStepType` to `pickleStepType` for consistency.
- Enhanced `GherkinDocumentBuilder` by exposing `transformNode` method.
- Added tests for parser error handling and step type assignment.
@Fried-man
Fried-man marked this pull request as draft August 25, 2026 02:08
@Fried-man Fried-man changed the title Test/dart maximum coverage [Dart] Full test coverage & CI enforcement Aug 25, 2026
@Fried-man
Fried-man marked this pull request as ready for review August 25, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant