[Dart] Improve test coverage & CI enforcement

.github/workflows/test-dart.yaml

@@ -52,14 +52,17 @@ jobs:
       - name: Install dependencies
         run: dart pub get --enforce-lockfile
 
+      - name: Install coverage tools
+        run: dart pub global activate coverage 1.15.0
+
       - name: Verify formatting
         run: dart format --output=none --set-exit-if-changed .
 
       - name: Analyze
         run: dart analyze
 
-      - name: Test
-        run: dart test
+      - name: Test & validate coverage
+        run: dart pub global run coverage:test_with_coverage --fail-under 60
 
       - name: Run acceptance tests
         run: make acceptance

dart/.gitignore

@@ -16,4 +16,8 @@ acceptance/
 
 # Directory created by dartdoc
 doc/api/
+
+# Directory created by dart test --coverage
+coverage/
+
 *.iml

dart/dialects_builtin.g.dart.jq

@@ -49,6 +49,7 @@ def dialect_body:
 
 "// GENERATED FILE - DO NOT MODIFY BY HAND\n"
 + "// dart format off\n"
++ "// coverage:ignore-file\n"
 + "\n"
 + "import 'package:cucumber_gherkin/src/language/gherkin_language_keywords.dart';\n"
 + "\n"

dart/gherkin-dart.razor

@@ -35,6 +35,7 @@
 // [Berp](https://github.com/gasparnagy/berp) using the shared `../gherkin.berp`
 // grammar.
 // dart format off
+// coverage:ignore-file
 import 'dart:collection';
 
 import 'package:cucumber_gherkin/src/exceptions/exceptions.dart';

dart/lib/src/compile_pickles.dart

@@ -203,7 +203,7 @@ messages.PickleStep _pickleStep(
   return messages.PickleStep(
     id: idGenerator(),
     text: _interpolate(step.text, variableCells, valueCells),
-    type: _pickleStepType(keywordType),
+    type: _pickleStepTypes[keywordType],
     argument: _pickleStepArgument(step, variableCells, valueCells),
     astNodeIds: astNodeIds,
   );
@@ -290,17 +290,10 @@ messages.StepKeywordType _effectiveKeywordType(
   return current;
 }
 
-messages.PickleStepType? _pickleStepType(messages.StepKeywordType keywordType) {
-  switch (keywordType) {
-    case messages.StepKeywordType.context:
-      return messages.PickleStepType.context;
-    case messages.StepKeywordType.action:
-      return messages.PickleStepType.action;
-    case messages.StepKeywordType.outcome:
-      return messages.PickleStepType.outcome;
-    case messages.StepKeywordType.unknown:
-      return messages.PickleStepType.unknown;
-    case messages.StepKeywordType.conjunction:
-      return null;
-  }
-}
+const Map<messages.StepKeywordType, messages.PickleStepType> _pickleStepTypes =
+    <messages.StepKeywordType, messages.PickleStepType>{
+      messages.StepKeywordType.context: messages.PickleStepType.context,
+      messages.StepKeywordType.action: messages.PickleStepType.action,
+      messages.StepKeywordType.outcome: messages.PickleStepType.outcome,
+      messages.StepKeywordType.unknown: messages.PickleStepType.unknown,
+    };

dart/lib/src/generate_messages.dart

@@ -70,9 +70,6 @@ List<messages.Envelope> generateMessages(
       e.errors.map((error) => _parseErrorEnvelope(error, source.uri)),
     );
     return result;
-  } on ParserException catch (e) {
-    result.add(_parseErrorEnvelope(e, source.uri));
-    return result;
   }
 
   final gherkinDocumentWithUri = messages.GherkinDocument(

dart/lib/src/language/dialects_builtin.g.dart

@@ -1,5 +1,6 @@
 // GENERATED FILE - DO NOT MODIFY BY HAND
 // dart format off
+// coverage:ignore-file
 
 import 'package:cucumber_gherkin/src/language/gherkin_language_keywords.dart';
 

dart/lib/src/parser/parser.g.dart

@@ -4,6 +4,7 @@
 // [Berp](https://github.com/gasparnagy/berp) using the shared `../gherkin.berp`
 // grammar.
 // dart format off
+// coverage:ignore-file
 import 'dart:collection';
 
 import 'package:cucumber_gherkin/src/exceptions/exceptions.dart';

dart/test/generate_messages_test.dart

@@ -65,4 +65,35 @@ void main() {
     expect(envelopes.single.parseError, isNotNull);
     expect(envelopes.single.parseError!.source.uri, 'broken.feature');
   });
+
+  test('maps several parser errors onto individual parseError envelopes', () {
+    final envelopes = generateMessages(
+      'oops one\n'
+          '\n'
+          'Feature: f\n'
+          '\n'
+          '  Scenario: s\n'
+          '    Given a step\n'
+          '\n'
+          'oops two\n',
+      'multi.feature',
+      const GherkinOptions(includeSource: false),
+    );
+
+    expect(envelopes.length, greaterThan(1));
+    expect(envelopes.every((envelope) => envelope.parseError != null), isTrue);
+    expect(envelopes.first.parseError!.source.uri, 'multi.feature');
+  });
+
+  test('preserves comments in a document without a feature', () {
+    final envelopes = generateMessages(
+      '# a standalone comment\n',
+      'empty.feature',
+    );
+
+    expect(envelopes, hasLength(2));
+    final document = envelopes.last.gherkinDocument!;
+    expect(document.feature, isNull);
+    expect(document.comments.single.text, '# a standalone comment');
+  });
 }