Add pairs_cte for early filtering in path-finding (#93)#289
Open
nicolas-geysse wants to merge 1456 commits intocwida:mainfrom
Open
Add pairs_cte for early filtering in path-finding (#93)#289nicolas-geysse wants to merge 1456 commits intocwida:mainfrom
nicolas-geysse wants to merge 1456 commits intocwida:mainfrom
Conversation
…on-weakly-connected-component Rework WCC implementation
…when-match-used-in-subquery Fix segmentation fault when match was used inside subquery
[still fixing some issues with aliases]
…with duckdb behaviour
…for-get_csr_v-and-get_csr_e Fix segmentation faults in csr v and e functions
…e function itself
Improve template bootstraper script
Update v1.3.2
This reverts commit b1edaff.
Merge with v1.4.1
Fix issues related to v1.4.1 release
Format fix
- Create CreatePathFindingPairsCTE() to isolate (src, dst) pairs with WHERE conditions - Modify GenerateShortestPathCTE() to use pairs_cte instead of direct cross join - Update AddPathQuantifierCondition() signature to accept parsed expressions - Add test for path-finding with filtered pairs and bounds - Fix unique_ptr conversion issues in summarize_property_graph.cpp Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreatePathFindingPairsCTE()function to isolate (src, dst) pairs with their WHERE conditions in a dedicated CTEGenerateShortestPathCTE()to referencepairs_cteinstead of doing a direct cross join between source and destination tablesAddPathQuantifierCondition()signature to acceptunique_ptr<ParsedExpression>for more flexibility{1,2}and{2,2}unique_ptrconversion issues insummarize_property_graph.cpp(unrelated bug fix)Motivation
This is a preparatory step for issue #93 (PathFindingOperator with two sinks). By isolating pairs in a CTE, we enable:
Test plan
pathfinding_pairs_bounds.testpasses (23 assertions)complex_matching.test)🤖 Generated with Claude Code