Fix bounded path results (issue #67)#290
Open
nicolas-geysse wants to merge 1457 commits intocwida:mainfrom
Open
Fix bounded path results (issue #67)#290nicolas-geysse wants to merge 1457 commits intocwida:mainfrom
nicolas-geysse wants to merge 1457 commits intocwida:mainfrom
Conversation
…on-weakly-connected-component Rework WCC implementation
…when-match-used-in-subquery Fix segmentation fault when match was used inside subquery
[still fixing some issues with aliases]
…with duckdb behaviour
…for-get_csr_v-and-get_csr_e Fix segmentation faults in csr v and e functions
…e function itself
Improve template bootstraper script
…unused-semicolons Remove unused semicolons
Update v1.3.2
This reverts commit b1edaff.
Merge with v1.4.1
Fix issues related to v1.4.1 release
Format fix
Push lower/upper bounds directly into the UDF instead of post-filtering with BETWEEN. This fixes cases where the shortest path is outside bounds but a longer path within bounds exists. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix std::move() missing in summarize_property_graph.cpp - Update test expectations to include self-loops found by iterativelengthbounded - Add TODO comments noting shortestpathbounded is needed for full fix Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iterativelengthboundedfunction that pushes lower/upper bounds directly into the UDFsummarize_property_graph.cpp(missingstd::move())Changes
iterativelengthbounded(csr_id, v_size, src, dst, lower, upper)→ booleanmatch.cppto useiterativelengthboundedinstead ofiterativelength+BETWEENfilterKnown Limitation
When using
ANY SHORTESTwith bounds, self-loops (e.g., Daniel→Daniel) may appear with path length 0 becauseshortestpathdoesn't respect bounds. A follow-up implementation ofshortestpathboundedwould fully resolve this.Test plan
bounded_shortest_path.testverifies the fix for issue Test if bounded path lengths get correct results #67Fixes #67
🤖 Generated with Claude Code