Add support for query() table function (issue #210)#293
Open
nicolas-geysse wants to merge 1456 commits intocwida:mainfrom
Open
Add support for query() table function (issue #210)#293nicolas-geysse wants to merge 1456 commits intocwida:mainfrom
nicolas-geysse wants to merge 1456 commits intocwida:mainfrom
Conversation
…on-weakly-connected-component Rework WCC implementation
…when-match-used-in-subquery Fix segmentation fault when match was used inside subquery
[still fixing some issues with aliases]
…with duckdb behaviour
…for-get_csr_v-and-get_csr_e Fix segmentation faults in csr v and e functions
…e function itself
Improve template bootstraper script
Update v1.3.2
This reverts commit b1edaff.
Merge with v1.4.1
Fix issues related to v1.4.1 release
Format fix
This fix enables DuckPGQ to work with DuckDB's query() table function:
```sql
FROM query('FROM GRAPH_TABLE (pg MATCH (a:Person) COLUMNS (a.id)) tmp');
```
## Problem
The previous architecture stored MatchExpression in DuckPGQState with an
integer index. When query() re-parsed the SQL, the context was different
and the expression was lost.
## Solution
Serialize MatchExpression to BLOB directly at parse time in TransformMatch,
making the expression self-contained with no dependency on external state.
Deserialize from BLOB in MatchBindReplace.
## Changes
- TransformMatch: serialize MatchExpression to BLOB at parse time
- MatchBindReplace: deserialize MatchExpression from BLOB
- Fix PathElement/SubPath serialization (call base class, use IDs 200+)
- Add BOUND_EXPRESSION case in ParsedExpression deserialization
- Fix MatchExpression serialization (call base class, use IDs 200-204)
- Remove unused transform_expression/match_index from DuckPGQState
- Add test for query() table function
Fixes cwida#210
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query()table functionProblem
The previous architecture stored
MatchExpressioninDuckPGQStatewith an integer index. Whenquery()re-parsed the SQL, the context was different and the expression was lost:Solution
Serialize
MatchExpressionto BLOB directly at parse time inTransformMatch, making the expression self-contained with no dependency on external state. Deserialize from BLOB inMatchBindReplace.Changes
transform_expression/match_indexfrom DuckPGQStateTest plan
test/sql/query_table_function.testpassesFixes #210
🤖 Generated with Claude Code