Update runtests.py: Fixed an issue where the return value of the function is incorrect.#747
Open
winner658 wants to merge 1 commit intocyrusimap:masterfrom
Open
Update runtests.py: Fixed an issue where the return value of the function is incorrect.#747winner658 wants to merge 1 commit intocyrusimap:masterfrom
winner658 wants to merge 1 commit intocyrusimap:masterfrom
Conversation
Fixed an issue where the return value of the function is incorrect.
Contributor
|
The Signed-off-by has to be in the commit message, not in the PR description. |
Contributor
|
Except this test is making sure that the exchange actually fails (in which case it returns |
Contributor
|
@winner658: Any progress on this PR 3 years after? Have you seen @quanah and @mistotebe comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the return value of the function is incorrect.https://github.com/cyrusimap/cyrus-sasl/issues/746
When the gssapi_channel_binding_mismatch_test function is bound successfully, 0 is returned. When an exception occurs, 1 is returned. The function is consistent with other functions of the same type.
Signed-off-by: Winner658 490514142@qq.com