db_*: call SASLDB_FREEPATH with the correct pointer#854
Open
flowerysong wants to merge 1 commit intocyrusimap:masterfrom
Open
db_*: call SASLDB_FREEPATH with the correct pointer#854flowerysong wants to merge 1 commit intocyrusimap:masterfrom
flowerysong wants to merge 1 commit intocyrusimap:masterfrom
Conversation
hyc
approved these changes
Mar 22, 2025
path sometimes gets overwritten with something that shouldn't be freed, while the registry value always needs to be freed. The easiest way to do this is to separate them. Signed-off-by: Paul Arthur <paul.arthur@flowerysong.com>
flowerysong
force-pushed
the
sasldb_freepath
branch
from
1b31798 to
dcd1866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathsometimes gets overwritten with something that shouldn't be freed, while the registry value always needs to be freed. The easiest way to do this is to separate them.This was previously fixed for LMDB in #840, but the other backends also have this issue and I think this version of the fix is a little more elegant so I applied it to
db_lmdb.cas well.