-
Notifications
You must be signed in to change notification settings - Fork 12
add support for the get_transform analog to set_transform
#264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts the formatting changes that were accidentally included with commit 0c21a73.
ziw-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I've left my comments inline.
|
Re: CI failure: please refer to the contributing guide. |
|
passed the precommit checks 👍 |
JoOkuma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: I remembered it wrong |
Isn't it as simple as returning the |
You're right! I mistakenly thought that |
…olution image metadata
…ve scale and translation transforms
…d of TransformationMeta
|
Separated into 2 unit tests, return plain list of floats instead of |
|
fixed test docstring and fixed case that was failing testing |
ziw-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @pattonw for your contribution!
|
Ready to merge if @JoOkuma doen't have further comments. |
given a set of scale and translation transforms, defined on both the group and individual individual images, each image will have a final scale and translation. These can now be conveniently retrieved with a little helper function that fetches all appropriate translations and applies them consecutively.
small test added to cover changes.