Skip to content

Conversation

@ziw-liu
Copy link
Contributor

@ziw-liu ziw-liu commented Jan 30, 2025

Use empty defaults when position, channel, and prefix metadata is not available.

Seems to fix #267.

@ziw-liu ziw-liu added bug Something isn't working μManager Micro-Manager files and metadata labels Jan 30, 2025
@ziw-liu ziw-liu requested review from ahillsley and ieivanov January 30, 2025 20:02
@ziw-liu ziw-liu changed the title Fix reading Dragonfly non-OpenCell datasets Fix reading Dragonfly non-OpenCell datasets with incomplete metadata Jan 30, 2025
@ziw-liu
Copy link
Contributor Author

ziw-liu commented Feb 4, 2025

@ahillsley Can you test with your dataset?

@ieivanov
Copy link
Contributor

ieivanov commented Feb 4, 2025

I tested with dataset that would otherwise throw error

...
    and self._mm_meta["Summary"]["Prefix"] == "raw_data"
KeyError: 'Prefix'

PR works well, merging.

@ieivanov ieivanov merged commit fe642a9 into main Feb 4, 2025
7 checks passed
@ieivanov ieivanov deleted the fix-dragonfly-non-opencell branch February 4, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working μManager Micro-Manager files and metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What to do when no metadata?

2 participants