-
Notifications
You must be signed in to change notification settings - Fork 12
Support metadata for .zarr converted from .nd2 using bioformats2raw conversion
#272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.zarr converted from .nd2 using bioformats2raw conversion.zarr converted from .nd2 using bioformats2raw conversion
Contributor
|
I'm noticing some OMERO-related issues. Might also be related to #270. |
Contributor
Author
Contributor
|
I'm trying to understand the changes to the metadata models, but the file in OP has been removed. @talonchandler can you point me to an example? |
Contributor
Author
|
Pardon me! Here's a test. Thank you @ziw-liu. |
ziw-liu
reviewed
Mar 11, 2025
Contributor
|
@talonchandler a more complete version of b2244ec is in main via #284 (hence the conflict). You can decide how to merge/rebase/cherrypick. |
ziw-liu
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains minor spec-mismatch bug fixes to enable
iohub infoto work with.zarrfiles converted from.nd2usingbioformats2rawconversion tool.For example:
prints
Note:
bioformats2rawseems to create single positions stacked one layer deeper than our typical single positions, so I calliohub infoon.zarr/0.Note: @ziw-liu @mattersoflight I'm tagging you here to keep you in the loop. I'll plan to request your review after we've completed a phase reconstruction during the week of March 3.