-
Notifications
You must be signed in to change notification settings - Fork 10
Support reading OME-Zarr 0.5 #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
afae0b4
wip
aliddell 63b3aa7
wip: 2025-02-27
aliddell dde33a0
Merge remote-tracking branch 'upstream/main' into 273-use-zarr-python-3
aliddell 0c0837c
Undo reformatting
aliddell e4c87b4
Remove unused imports
aliddell abfd029
Fix miscellaneous failing tests.
aliddell 61045d4
Get rename_well working.
aliddell 9800d96
sort import
ziw-liu 2516c9b
Read MMStack with Zarr v3 (#293)
ziw-liu 1404000
Merge branch 'main' into 273-use-zarr-python-3
ziw-liu 2a2f75f
add rich for zarr v3 print tree
ziw-liu 26adb5e
skip tests that require ome-zarr-py
ziw-liu dd6d994
fix file list checking
ziw-liu b9c6ccd
fix commas
ziw-liu 8a427c6
stringify path names
ziw-liu ce6e0a9
Merge branch 'main' into 273-use-zarr-python-3
ziw-liu f50efcb
detect ome key in reader
ziw-liu c48309f
allow multiscales to not have version
ziw-liu c7d4e1d
wip: allow reading v0.5 images
ziw-liu 90ce666
normalize store path
ziw-liu 8507fec
Merge branch 'zarr3-dev' into ome-zarr-0.5
ziw-liu 6648e95
update docstring
ziw-liu 7e94726
remove unused import
ziw-liu f7c86fe
remove zarr-python synchronizer
ziw-liu 77146dd
allow empty zarr examples
ziw-liu d60ff07
add example json files
ziw-liu 81e88f0
fixture for example v0.5 HCS dataset
ziw-liu 27201c7
unify ome container unwrapping
ziw-liu 8f811ab
run PR tests for all target branches
ziw-liu 3aa13f6
test with absolute paths
ziw-liu 31aa28d
avoid big endian test cases
ziw-liu 3f03172
avoid yanked versions
ziw-liu 63971f9
fix zarr-python breakage
ziw-liu a37a13f
revert keyword argument name
ziw-liu c19c80d
fix version detection after zarr-python breakage
ziw-liu c6bec61
test with absolute path
ziw-liu 140b498
Merge branch 'zarr3-dev' into ome-zarr-0.5
ziw-liu c091eb9
Revert "allow empty zarr examples"
ziw-liu 6160961
Test reading NGFF v0.5 with acquire-zarr
aliddell c20417f
Merge remote-tracking branch 'upstream/ome-zarr-0.5' into ome-zarr-0.5
aliddell 4f37959
check binary values
ziw-liu d3ceea9
simplify file mode switch
ziw-liu 2f1f00b
remove redundant deletion
ziw-liu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ name: lint, style, and tests | |
on: | ||
pull_request: | ||
branches: | ||
- main | ||
- "*" | ||
|
||
jobs: | ||
style: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
""" | ||
Data model classes with validation for OME-NGFF metadata. | ||
Developed against OME-NGFF v0.4 and ome-zarr v0.9 | ||
Developed against OME-NGFF v0.4/0.5.2 and ome-zarr v0.9. | ||
|
||
Attributes are 'snake_case' with aliases to match NGFF names in JSON output. | ||
See https://ngff.openmicroscopy.org/0.4/index.html#naming-style | ||
|
@@ -219,7 +219,9 @@ class VersionMeta(MetaBase): | |
"""OME-NGFF spec version. Default is the current version (0.4).""" | ||
|
||
# SHOULD | ||
version: Literal["0.1", "0.2", "0.3", "0.4"] = "0.4" | ||
version: Literal["0.1", "0.2", "0.3", "0.4", "0.5"] | None = Field( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Workaround for ome/ngff#309. |
||
default=None, exclude=lambda v: v is None | ||
) | ||
|
||
|
||
class MultiScaleMeta(VersionMeta): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.