Skip to content

Enable tests with ome-zarr-py #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ziw-liu merged 28 commits into from
Aug 20, 2025
Merged

Enable tests with ome-zarr-py #297

ziw-liu merged 28 commits into from
Aug 20, 2025

Conversation

@ziw-liu
Copy link
Contributor

@ziw-liu ziw-liu commented May 6, 2025 •
edited
Loading

  • Tests passes with ome-zarr-py 0.12.0.
  • Use assert_allclose since its recommended over asset_array_almost_equal.

aliddell and others added 17 commits February 27, 2025 09:40
@aliddell
wip
afae0b4
@aliddell
wip: 2025-02-27
63b3aa7
@aliddell
Merge remote-tracking branch 'upstream/main' into 273-use-zarr-python-3
dde33a0
@aliddell
Undo reformatting
0c0837c
@aliddell
Remove unused imports
e4c87b4
@aliddell
Fix miscellaneous failing tests.
abfd029
@aliddell
Get rename_well working.
61045d4
@ziw-liu
sort import
9800d96
@ziw-liu
Read MMStack with Zarr v3 (#293)
2516c9b 
* use fsspec as a wrapper for ZarrTiffStore

* update deprecated readers and tests

* document the helper function

* add back the binary check after a flag

* use kwarg for file mode in reader

* restore dtype attribute

* restore opening zarr with dask

* stringify path name

* remove redundant dtype
@ziw-liu
Merge branch 'main' into 273-use-zarr-python-3
1404000
@ziw-liu
add rich for zarr v3 print tree
2a2f75f
@ziw-liu
skip tests that require ome-zarr-py
26adb5e
@ziw-liu
fix file list checking
dd6d994 
it doesn't matter what the order is
@ziw-liu
fix commas
b9c6ccd
@ziw-liu
stringify path names
8a427c6
@ziw-liu
Merge branch 'main' into 273-use-zarr-python-3
ce6e0a9
@aliddell
test_rename_well no longer broken, remove mark
685349f
@ziw-liu ziw-liu mentioned this pull request May 6, 2025
Closed
@ziw-liu
from_positions is actually broken
210c077 
this is not related to ome-zarr-py
@ziw-liu ziw-liu added this to the 0.3.0 milestone May 13, 2025
@ziw-liu ziw-liu force-pushed the zarr-python-v3-ome-zarr-py branch from b0f3236 to d3cf348 Compare May 13, 2025 17:42
Base automatically changed from 273-use-zarr-python-3 to zarr3-dev May 19, 2025 18:35
@ziw-liu ziw-liu added NGFF OME-NGFF (OME-Zarr format) maintenance Maintenance work CI Continuous integration labels Jul 31, 2025
@ziw-liu
Copy link
Contributor Author

ziw-liu commented Aug 18, 2025

Needs 6787d64 for CI to pass.

@ziw-liu ziw-liu marked this pull request as ready for review August 18, 2025 21:07
srivarra
srivarra approved these changes Aug 19, 2025
View reviewed changes
Copy link
Collaborator

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ziw-liu ziw-liu merged commit 8713e9b into zarr3-dev Aug 20, 2025
7 checks passed
@ziw-liu ziw-liu deleted the zarr-python-v3-ome-zarr-py branch August 20, 2025 16:12
@srivarra srivarra mentioned this pull request Sep 8, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srivarra srivarra srivarra approved these changes

@aliddell aliddell Awaiting requested review from aliddell

@edyoshikun edyoshikun Awaiting requested review from edyoshikun

Assignees

No one assigned

Labels

CI Continuous integration maintenance Maintenance work NGFF OME-NGFF (OME-Zarr format)

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ziw-liu @srivarra @aliddell