-
Notifications
You must be signed in to change notification settings - Fork 12
Added Position.compute_pyramids
#348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Sorry if I'm being a pain in the neck during this review, I think |
No I prefer this haha, I'm learning a lot from you so I think it's a good thing tbh. |
…ted checking chunks for divisibility
|
I think we are very close! I'm not fully done reviewing the PR, but before I forget - it looks like |
|
@ieivanov I had to make some adjustments due to |
|
I think this PR looks good! Sorry, I'll change my mind on one thing - we should rename Before we merge I'd love to get a review from @JoOkuma. We should also refactor czbiohub-sf/biahub#12 to use these latest changes - this will tell us if we've gotten the API right. |
Adds
Position.compute_pyramids