chore: Update Windows CI runners to windows-2022 #6292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- windows-2019 is deprecated by GitHub Actions - Updated all workflow files to use windows-2022 - Issue #1906 that previously blocked windows-2022 is now closed - Files updated: - .github/workflows/release-downloads-nuget.yml - .github/workflows/release-downloads.yml - .github/workflows/xunit-tests-reusable.yml - .github/workflows/integration-tests-reusable.yml
Chores don't warrant news items as they have no user-visible impact
- Scripts/package.py also referenced windows-2019 for release packaging - Updated to windows-2022 for consistency with CI workflows - Ensures release packages are built with current Windows runner
MikaelMayer
reviewed
Jul 1, 2025
Co-authored-by: Mikaël Mayer <[email protected]>
keyboardDrummer
previously approved these changes
Jul 2, 2025
|
This breaks the release script, because we don't publish all z3 binaries from solver-builds. Once dafny-lang/solver-builds#2 is merged, we can update package.py to make this also work on Windows. |
|
Two apparently legitimate windows failures. |
…ny-lang/dafny into chore/fix-windows-ci-targets
MikaelMayer
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Windows CI targets are using
windows-2019which is deprecated by GitHub Actions and may cause CI failures as GitHub phases out support for older runner versions.Solution
Updated all references from
windows-2019towindows-2022across the entire codebase:Files Updated:
.github/workflows/release-downloads-nuget.yml.github/workflows/release-downloads.yml.github/workflows/xunit-tests-reusable.yml.github/workflows/integration-tests-reusable.ymlScripts/package.py(release packaging script)Background:
windows-2022is now closedwindows-2019is deprecated and should be replacedwindows-2022is the current recommended Windows runnerTesting
✅ Comprehensive Validation Completed:
Manual Workflow Testing:
PR CI Validation:
Key Metrics:
Test Evidence:
Impact
Type
Status: Ready for merge - Comprehensive testing validates windows-2022 compatibility across all workflows.