chore: Update Windows CI runners to windows-2022

.github/workflows/integration-tests-reusable.yml

@@ -31,15 +31,15 @@ jobs:
       - name: Populate OS list (all platforms)
         id: populate-os-list-all
         if: inputs.all_platforms
-        run: echo "os-list=[\"ubuntu-22.04\", \"macos-13\", \"windows-2019\"]" >> $GITHUB_OUTPUT
+        run: echo "os-list=[\"ubuntu-22.04\", \"macos-13\", \"windows-2022\"]" >> $GITHUB_OUTPUT
       - name: Populate OS list (one platform)
         id: populate-os-list-one
         if: "!inputs.all_platforms"
         run: echo "os-list=[\"ubuntu-22.04\"]" >> $GITHUB_OUTPUT
       - name: Populate OS mapping for package.py
         id: populate-os-mapping
         run: |
-          echo "os-mapping={\"ubuntu-22.04\": \"ubuntu\", \"macos-13\": \"macos\", \"windows-2019\": \"windows\"}" >> $GITHUB_OUTPUT
+          echo "os-mapping={\"ubuntu-22.04\": \"ubuntu\", \"macos-13\": \"macos\", \"windows-2022\": \"windows\"}" >> $GITHUB_OUTPUT
       - name: Populate target runtime version list (all platforms)
         id: populate-target-runtime-version-all
         if: inputs.all_platforms

.github/workflows/release-downloads-nuget.yml

@@ -31,8 +31,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # This workflow breaks on windows-2022: https://github.com/dafny-lang/dafny/issues/1906
-        os: [ ubuntu-22.04, macos-13, windows-2019 ]
+        os: [ ubuntu-22.04, macos-13, windows-2022 ]
 
     steps:
     - name: OS
@@ -110,8 +109,7 @@ jobs:
         # Hopefully we can automatically populate this list in the future,
         # but note we need to skip Dafny since nuget install doesn't work for dotnet tools.
         library-name: [ DafnyPipeline, DafnyServer, DafnyLanguageServer, DafnyRuntime, DafnyCore, DafnyDriver ]
-        # This workflow breaks on windows-2022: https://github.com/dafny-lang/dafny/issues/1906
-        os: [ ubuntu-latest, ubuntu-22.04, macos-13, windows-2019 ]
+        os: [ ubuntu-latest, ubuntu-22.04, macos-13, windows-2022 ]
 
     steps:
     # Verify that the dependencies of the libraries we publish (e.g. DafnyLanguageServer)

.github/workflows/release-downloads.yml

@@ -17,17 +17,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # This workflow breaks on windows-2022: https://github.com/dafny-lang/dafny/issues/1906
-        os: [ ubuntu-latest, ubuntu-22.04, macos-13, windows-2019 ]
+        os: [ ubuntu-latest, ubuntu-22.04, macos-13, windows-2022 ]
         include:
         - os:  'ubuntu-latest'
           osn: 'ubuntu-22.04'
         - os:  'ubuntu-22.04'
           osn: 'ubuntu-22.04'
         - os:  'macos-13'
           osn: 'x64-macos-13'
-        - os:  'windows-2019'
-          osn: 'windows-2019'
+        - os:  'windows-2022'
+          osn: 'windows-2022'
     # There is no hosted environment for Ubuntu 14.04 or for debian
 
     # Java is installed by default, but we need to select 18

.github/workflows/xunit-tests-reusable.yml

@@ -49,13 +49,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-22.04, windows-2019, macos-13]
+        os: [ubuntu-22.04, windows-2022, macos-13]
         iteration: ${{ fromJson(needs.populate-matrix-dimensions.outputs.iterations) }}
         include:
           - os: macos-13
             suffix: osx
             chmod: true
-          - os: windows-2019
+          - os: windows-2022
             suffix: win
             chmod: false
           - os: ubuntu-22.04

Scripts/package.py

@@ -290,7 +290,7 @@ def main():
     releases = [ Release("macos-11",       "x64", args.version, args.out),
                  Release("macos-11",     "arm64", args.version, args.out),
                  Release("ubuntu-20.04",   "x64", args.version, args.out),
-                 Release("windows-2019",   "x64", args.version, args.out) ]
+                 Release("windows-2022",   "x64", args.version, args.out) ]
     if args.os:
         releases = list(filter(lambda release: release.os_name == args.os, releases))
     if args.platform: