[dg] Add option to output html docs to file instead of tmpfile/browser #27632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Base automatically changed from
benpankow/existing-code-location-test
to
master
February 6, 2025 22:03
benpankow
force-pushed
the
benpankow/docs-cmd-option-to-output
branch
from
3fd60d4 to
8562905
Compare
benpankow
force-pushed
the
benpankow/docs-cmd-option-to-output
branch
from
8562905 to
7c89080
Compare
benpankow
force-pushed
the
benpankow/docs-cmd-option-to-output
branch
from
2ae1a99 to
101ddfb
Compare
smackesey
reviewed
Feb 10, 2025
There was a problem hiding this comment.
This is good but I want to quibble over the API/defaults. I would prefer:
- by default just dump the output to terminal (current
--output cli) - no
--outputoption --browserflag that opens browser
@schrockn what are your thoughts
I think the in-browser docs is more useful for the average user than the raw html, so it feels a bit wrong to gate that behind an option. I guess if all docs present that option first maybe it's fine |
|
I think it should default to browswer |
schrockn
approved these changes
Feb 11, 2025
braunjj
pushed a commit
that referenced
this pull request
Feb 14, 2025
#27632) ## Summary I selfishly want this functionality for e2e tests, but I also think users might find it helpful
brentjericho
pushed a commit
to brentjericho/dagster
that referenced
this pull request
Feb 21, 2025
dagster-io#27632) ## Summary I selfishly want this functionality for e2e tests, but I also think users might find it helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I selfishly want this functionality for e2e tests, but I also think users might find it helpful