[dg docs] Add docs e2e test, screenshot generation for component type tutorial #27633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...snippets_tests/snippet_checks/guides/components/test_components_docs_creating_a_component.py
Show resolved
Hide resolved
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-ciyp76rio-elementl.vercel.app Direct link to changed pages: |
benpankow
force-pushed
the
benpankow/docs-cmd-option-to-output
branch
from
3fd60d4 to
8562905
Compare
benpankow
force-pushed
the
benpankow/docs-test-creating-component
branch
from
d7e1c6f to
0713466
Compare
benpankow
force-pushed
the
benpankow/docs-cmd-option-to-output
branch
from
8562905 to
7c89080
Compare
benpankow
force-pushed
the
benpankow/docs-test-creating-component
branch
2 times, most recently
from
1e41328 to
47b7086
Compare
benpankow
force-pushed
the
benpankow/docs-cmd-option-to-output
branch
from
2ae1a99 to
101ddfb
Compare
benpankow
force-pushed
the
benpankow/docs-test-creating-component
branch
from
47b7086 to
81cc387
Compare
Base automatically changed from
benpankow/docs-cmd-option-to-output
to
master
February 13, 2025 16:37
benpankow
force-pushed
the
benpankow/docs-test-creating-component
branch
from
81cc387 to
13a3afe
Compare
braunjj
pushed a commit
that referenced
this pull request
Feb 14, 2025
… tutorial (#27633) ## Summary Noticed these docs are already(!) out of date (uses generate instead of scaffold verbiage, `.resolve_params` instead of `.resolve`), so added a brief test. Also played with some screenshot generation. Didn't touch the last section on advanced custom resolution because the code snippets are pretty pseudocode-y, bonus points if someone wants to put that under test. ## Test Plan See [new docs](https://dagster-docs-agnb11wv4-elementl.vercel.app/guides/preview/components/creating-a-component) vs [existing docs](https://docs.dagster.io/guides/preview/components/creating-a-component)
brentjericho
pushed a commit
to brentjericho/dagster
that referenced
this pull request
Feb 21, 2025
… tutorial (dagster-io#27633) ## Summary Noticed these docs are already(!) out of date (uses generate instead of scaffold verbiage, `.resolve_params` instead of `.resolve`), so added a brief test. Also played with some screenshot generation. Didn't touch the last section on advanced custom resolution because the code snippets are pretty pseudocode-y, bonus points if someone wants to put that under test. ## Test Plan See [new docs](https://dagster-docs-agnb11wv4-elementl.vercel.app/guides/preview/components/creating-a-component) vs [existing docs](https://docs.dagster.io/guides/preview/components/creating-a-component)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed these docs are already(!) out of date (uses generate instead of scaffold verbiage,
.resolve_paramsinstead of.resolve), so added a brief test. Also played with some screenshot generation.Didn't touch the last section on advanced custom resolution because the code snippets are pretty pseudocode-y, bonus points if someone wants to put that under test.
Test Plan
See new docs vs existing docs