[dg] Rename get_schema to get_model_cls #28944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrockn
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
python_modules/libraries/dagster-components/dagster_components/component/component.py
Outdated
Show resolved
Hide resolved
OwenKephart
approved these changes
Apr 2, 2025
schrockn
force-pushed
the
schrockn/root-model
branch
from
71e8e7a to
fdfd0a5
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-10b4dri1p-elementl.vercel.app Direct link to changed pages: |
schrockn
force-pushed
the
schrockn/root-model
branch
from
fdfd0a5 to
0975cad
Compare
schrockn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I think we should rename
get_schematoget_model_cls. Assuming everyone agrees wiill update docs as well.How I Tested These Changes
BK
Changelog
Component.get_schemahas been renamed toComponent.get_model_cls. Override that instead to customize the frontend of your component.Component.get_schemawill continue to work for the time being but will be removed at some point.