[dg] Refactor PackageEntry types #28953
Open
+156
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 2, 2025
schrockn
reviewed
Apr 3, 2025
Comment on lines
+88
to
+94
| @overload | ||
| def get_type_data(self, entry_type: Literal["component"]) -> Optional[ComponentTypeData]: ... | ||
|
|
||
| @whitelist_for_serdes | ||
| @record | ||
| class ComponentTypeSnap(PackageEntrySnap): | ||
| schema: Optional[dict[str, Any]] | ||
| @overload | ||
| def get_type_data( | ||
| self, entry_type: Literal["scaffold-target"] | ||
| ) -> Optional[ScaffoldTargetTypeData]: ... |
There was a problem hiding this comment.
this is a neat use of type system
schrockn
approved these changes
Apr 3, 2025
OwenKephart
force-pushed
the
04-02-_dg_libraryobject_-_packageentry
branch
from
b5fa109 to
8e5ee9f
Compare
OwenKephart
force-pushed
the
04-02-_dg_refactor_packageentry_types
branch
from
1a156b6 to
4d5c9c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Internal refactor that gives each package entry an arbitrary list of types. Right now, those types are just scaffold-target and component, but we can add more in the future (e.g. Resolvable)
This is useful for categorizing and filtering entries. Previously, we had a hierarchical system (where ComponentSnap was a subclass of LibraryObjectSnap), which was hard to extend and filter by, as all of these types somewhat overlap with eachother
How I Tested These Changes
Changelog
NOCHANGELOG