Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dg] dg list packages #28954

Open
wants to merge 1 commit into
base: 04-02-_dg_refactor_packageentry_types
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

@OwenKephart OwenKephart commented Apr 2, 2025

Summary & Motivation

Adds a new dg list packages command that outputs organized information about the contents of each dg-enabled package.

Example output (interested in feedback here!):

Screenshot 2025-04-02 at 1.08.03 PM.png

Screenshot 2025-04-02 at 1.08.12 PM.png

Screenshot 2025-04-02 at 1.08.37 PM.png

Screenshot 2025-04-02 at 1.56.45 PM.png

How I Tested These Changes

Changelog

NOCHANGELOG

Copy link
Contributor Author

OwenKephart commented Apr 2, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Apr 2, 2025

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-luwg7ah59-elementl.vercel.app
https://04-02-dg-dg-list-packages.archive.dagster-docs.io

Direct link to changed pages:

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great but I think we need a final bikeshedding sessions to evaulator "Key" versus "Entry" versus "Types"

Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be easier just to rebase and squash this PR with #28987 and consider it holistically

@OwenKephart OwenKephart force-pushed the 04-02-_dg_refactor_packageentry_types branch from 1a156b6 to 4d5c9c7 Compare April 3, 2025 23:26
@OwenKephart OwenKephart force-pushed the 04-02-_dg_dg_list_packages branch from e21679f to 49d9b65 Compare April 3, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants