[dg] Remove dg list component-type #29095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
232a875 to
752f9c4
Compare
smackesey
force-pushed
the
sean/dg/rm-list-component-type
branch
from
1127425 to
e49eb2a
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
smackesey
force-pushed
the
sean/dg/rm-list-component-type
branch
from
e49eb2a to
8ebaf80
Compare
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
752f9c4 to
081095c
Compare
smackesey
force-pushed
the
sean/dg/rm-list-component-type
branch
from
8ebaf80 to
1ba6e67
Compare
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
081095c to
7a42174
Compare
OwenKephart
approved these changes
Apr 8, 2025
| ): | ||
| output.append({"key": entry.key.to_typename(), "summary": entry.summary}) | ||
| for entry in sorted(registry.get_objects(), key=lambda x: x.key.to_typename()): | ||
| output.append( |
There was a problem hiding this comment.
totally fine for the purposes of this PR but my dream is for the "DagsterOuterTable / DagsterInnerTable" stuff to have functionality to auto-generate the json-ified output based on the table structure
e.g. right now this output is still kinda bad because it doesn't include the plugin name
this PR doesn't make it worse or anything, just logging for the future
smackesey
force-pushed
the
sean/dg/package-object-renames
branch
from
7a42174 to
4be0e00
Compare
smackesey
force-pushed
the
sean/dg/rm-list-component-type
branch
from
1ba6e67 to
0c0433f
Compare
smackesey
force-pushed
the
sean/dg/rm-list-component-type
branch
from
0c0433f to
77b0c62
Compare
smackesey
force-pushed
the
sean/dg/rm-list-component-type
branch
from
77b0c62 to
ce35eda
Compare
smackesey
added a commit
that referenced
this pull request
Apr 9, 2025
## Summary & Motivation Remove `dg list component-type`. Convert `dg list component-type` tests to use `dg list plugins` instead. ## How I Tested These Changes Modified existing tests. ## Changelog The `dg list component-type` command has been removed. There is a new `dg list plugins` with output that is a superset of `dg list component-type`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Remove
dg list component-type. Convertdg list component-typetests to usedg list pluginsinstead.How I Tested These Changes
Modified existing tests.
Changelog
The
dg list component-typecommand has been removed. There is a newdg list pluginswith output that is a superset ofdg list component-type.