[dg] Change sure config from dg.toml -> .dg.toml #29107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2025
smackesey
changed the base branch from
sean/dg/package-object-renames
to
graphite-base/29107
smackesey
force-pushed
the
graphite-base/29107
branch
from
4be0e00 to
e88974e
Compare
smackesey
force-pushed
the
sean/dg/change-user-config-to-.dg.toml
branch
from
f75f38f to
4a2b611
Compare
benpankow
approved these changes
Apr 8, 2025
smackesey
added a commit
that referenced
this pull request
Apr 9, 2025
## Summary & Motivation Change the user dg config file from `dg.toml` to `.dg.toml` on Unix. This means that there will be no `dg.toml` file in the home directory that will be discovered as a containing workspace. ## How I Tested These Changes Manually, by checking that settings from `~/.dg.toml` were inherited and those from `~/dg.toml` were not. Used this approach because it's hard to use an automated test when reading from the home directory. ## Changelog The `dg` user config file on Unix is now looked for at `~/.dg.toml` instead of `~/dg.toml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Change the user dg config file from
dg.tomlto.dg.tomlon Unix. This means that there will be nodg.tomlfile in the home directory that will be discovered as a containing workspace.How I Tested These Changes
Manually, by checking that settings from
~/.dg.tomlwere inherited and those from~/dg.tomlwere not. Used this approach because it's hard to use an automated test when reading from the home directory.Changelog
The
dguser config file on Unix is now looked for at~/.dg.tomlinstead of~/dg.toml.