[1/2] Asset Health Observe UIs phase 1 #29151
Conversation
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 29e1baf. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 29e1baf. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/asset-data/AssetLiveDataProvider.tsx
Outdated
Show resolved
Hide resolved
…eDataProvider.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
share cache manager share cache manager share cache manager share cache manager share cache manager
…alazarm/asset-health-ui
…gster into salazarm/asset-health-ui
…ter-io/dagster into salazarm/asset-health-ui
…/dagster-io/dagster into salazarm/asset-health-ui
…alazarm/live-data-provider
js_modules/dagster-ui/packages/ui-core/src/assets/AssetsCatalogTableV2.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-data/AssetHealthDataProvider.tsx
Outdated
Show resolved
Hide resolved
…ter-io/dagster into salazarm/asset-health-ui
python_modules/dagster-test/dagster_test/toys/seed_asset_failure_events.py
Show resolved
Hide resolved
| useDebugChanged([ | ||
| liveDataByNode, | ||
| filtered, | ||
| assets, | ||
| errorState, | ||
| filterInput, | ||
| loading, | ||
| assetsLoading, | ||
| error, | ||
| selectedTab, | ||
| groupedByStatus, | ||
| content, | ||
| healthDataLoading, | ||
| assetsLoading, | ||
| loading, | ||
| error, | ||
| selectedTab, | ||
| groupedByStatus, | ||
| content, | ||
| ]); |
There was a problem hiding this comment.
There are duplicate dependencies in the useDebugChanged array. The following dependencies appear twice:
assetsLoadingloadingerrorselectedTabgroupedByStatuscontent
Removing these duplicates would improve code clarity and prevent unnecessary debug logging.
| useDebugChanged([ | |
| liveDataByNode, | |
| filtered, | |
| assets, | |
| errorState, | |
| filterInput, | |
| loading, | |
| assetsLoading, | |
| error, | |
| selectedTab, | |
| groupedByStatus, | |
| content, | |
| healthDataLoading, | |
| assetsLoading, | |
| loading, | |
| error, | |
| selectedTab, | |
| groupedByStatus, | |
| content, | |
| ]); | |
| useDebugChanged([ | |
| liveDataByNode, | |
| filtered, | |
| assets, | |
| errorState, | |
| filterInput, | |
| loading, | |
| assetsLoading, | |
| error, | |
| selectedTab, | |
| groupedByStatus, | |
| content, | |
| healthDataLoading, | |
| ]); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
[INTERNAL_BRANCH=salazarm/asset-health-ui]
Implements phase 1 of the asset health observe UIs as demoed at the R&D demos on Friday.
Test Plan
R&D demo