Skip to content

DagsterInstance.report_dagster_event timestamp override #29406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpeng817 merged 2 commits into from
May 1, 2025
Merged

DagsterInstance.report_dagster_event timestamp override #29406

dpeng817 merged 2 commits into from
May 1, 2025

Conversation

@dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Apr 18, 2025 •
edited
Loading

Summary & Motivation

Allow overriding the timestamp set on the event log entry. This allows for backdating events.

How I Tested These Changes

Added a new storage test

@dpeng817 dpeng817 mentioned this pull request Apr 18, 2025
Merged
@dpeng817 Graphite App
Copy link
Contributor Author

dpeng817 commented Apr 18, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 18, 2025
Merged
Merged
@dpeng817 dpeng817 requested review from OwenKephart and prha April 18, 2025 17:02
@dpeng817 dpeng817 marked this pull request as ready for review April 18, 2025 17:02
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 16ce37e to 558fac0 Compare April 18, 2025 17:33
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 7736fee to 0c863ec Compare April 18, 2025 17:33
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 558fac0 to 18ec729 Compare April 18, 2025 18:00
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 0c863ec to 02ff3cd Compare April 18, 2025 18:00
prha
prha approved these changes Apr 22, 2025
View reviewed changes
python_modules/dagster/dagster_tests/storage_tests/utils/event_log_storage.py Outdated
assert failed_partitions_by_step_key == failed_partitions

def test_timestamp_overrides(self, storage, instance: DagsterInstance) -> None:
# instance.report_dagster_event(
Copy link
Member

@prha prha Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 18ec729 to e2cf599 Compare April 23, 2025 16:52
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 02ff3cd to 2e156a6 Compare April 23, 2025 16:52
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from e2cf599 to dcd8450 Compare April 23, 2025 22:00
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 2e156a6 to aca4779 Compare April 23, 2025 22:00
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from dcd8450 to ad88867 Compare April 23, 2025 22:28
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from aca4779 to 01d7a9a Compare April 23, 2025 22:28
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from ad88867 to 1042d1d Compare April 23, 2025 23:10
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 01d7a9a to 9382c81 Compare April 23, 2025 23:10
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 1042d1d to f6b9f49 Compare April 23, 2025 23:36
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 9382c81 to f384500 Compare April 23, 2025 23:36
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from f6b9f49 to 2923b33 Compare April 24, 2025 00:08
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from f384500 to 022d09e Compare April 24, 2025 00:08
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 2923b33 to 6125bf2 Compare April 24, 2025 00:51
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 022d09e to 6470700 Compare April 24, 2025 00:51
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 6125bf2 to ad57047 Compare April 24, 2025 00:59
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 6470700 to 051057d Compare April 24, 2025 00:59
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from ad57047 to c33f358 Compare April 24, 2025 04:19
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 051057d to f0e31a5 Compare April 24, 2025 04:19
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from c33f358 to 9417cf2 Compare April 24, 2025 04:29
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from f0e31a5 to 8207c6f Compare April 24, 2025 04:29
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 9417cf2 to 813d40f Compare April 24, 2025 05:07
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 8207c6f to 67c8514 Compare April 24, 2025 05:07
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 813d40f to 2a1333e Compare April 24, 2025 16:54
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 67c8514 to 4f426fa Compare April 24, 2025 16:54
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 2a1333e to 7e32499 Compare April 24, 2025 23:48
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 4f426fa to 543adf6 Compare April 24, 2025 23:48
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 7e32499 to e30a5d8 Compare April 25, 2025 00:15
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 543adf6 to 318ce50 Compare April 25, 2025 00:15
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from e30a5d8 to bafa107 Compare April 25, 2025 00:30
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 318ce50 to 40306f7 Compare April 25, 2025 00:30
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from bafa107 to 560b46c Compare April 25, 2025 02:06
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 40306f7 to dc28ff0 Compare April 25, 2025 02:06
This was referenced Apr 25, 2025
Closed
Merged
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from 560b46c to a7a7759 Compare April 29, 2025 00:46
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from dc28ff0 to 803e7e4 Compare April 29, 2025 00:46
@dpeng817 dpeng817 mentioned this pull request Apr 30, 2025
Merged
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from a7a7759 to f03f68a Compare April 30, 2025 19:42
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 803e7e4 to eb8511b Compare April 30, 2025 19:42
@dpeng817 dpeng817 mentioned this pull request Apr 30, 2025
Merged
@dpeng817 dpeng817 force-pushed the dpeng817/runs_obey_event_timestamp branch from f03f68a to 834b9f0 Compare April 30, 2025 20:47
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from eb8511b to fde1ebf Compare April 30, 2025 20:47
@dpeng817 dpeng817 mentioned this pull request Apr 30, 2025
Merged
@dpeng817
[dagster-airlift] apply storage changes to airlift (#29407)
f00928c 
## Summary & Motivation
Apply the downstack storage changes to Airlift - specifically:
- Create correctly dated historical runs
- Create correctly dated events
## How I Tested These Changes
- Altered existing tests to have additional assertions around timing.
@dpeng817 dpeng817 merged commit 126d4fd into dpeng817/runs_obey_event_timestamp May 1, 2025
1 check was pending
@dpeng817 dpeng817 deleted the dpeng817/timestamp_event_reporting_override branch May 1, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prha prha prha approved these changes

@OwenKephart OwenKephart Awaiting requested review from OwenKephart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpeng817 @prha