Skip to content

[dagster-airlift] apply storage changes to airlift #29407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dpeng817/timestamp_event_reporting_override
Choose a base branch
from
Open

[dagster-airlift] apply storage changes to airlift #29407

wants to merge 1 commit into from

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Apr 18, 2025 •
edited
Loading

Summary & Motivation

Apply the downstack storage changes to Airlift - specifically:

  • Create correctly dated historical runs
  • Create correctly dated events

How I Tested These Changes

  • Altered existing tests to have additional assertions around timing.

This was referenced Apr 18, 2025
Open
Open
@dpeng817 Graphite App
Copy link
Contributor Author

dpeng817 commented Apr 18, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dpeng817 dpeng817 mentioned this pull request Apr 18, 2025
Open
@dpeng817 dpeng817 requested review from OwenKephart and prha April 18, 2025 17:04
@dpeng817 dpeng817 marked this pull request as ready for review April 18, 2025 17:04
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 7736fee to 0c863ec Compare April 18, 2025 17:33
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 6a28d22 to 996fa86 Compare April 18, 2025 17:33
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 0c863ec to 02ff3cd Compare April 18, 2025 18:00
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 996fa86 to bd28c1e Compare April 18, 2025 18:00
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 02ff3cd to 2e156a6 Compare April 23, 2025 16:52
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from bd28c1e to 36785cb Compare April 23, 2025 16:52
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 2e156a6 to aca4779 Compare April 23, 2025 22:00
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 36785cb to ef3cb88 Compare April 23, 2025 22:00
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from aca4779 to 01d7a9a Compare April 23, 2025 22:28
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from ef3cb88 to 35d476e Compare April 23, 2025 22:28
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 01d7a9a to 9382c81 Compare April 23, 2025 23:10
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 35d476e to 26f7ffb Compare April 23, 2025 23:10
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 9382c81 to f384500 Compare April 23, 2025 23:36
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 26f7ffb to 884f23d Compare April 23, 2025 23:36
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from f384500 to 022d09e Compare April 24, 2025 00:08
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 884f23d to e8f68be Compare April 24, 2025 00:08
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 022d09e to 6470700 Compare April 24, 2025 00:51
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from e8f68be to ca86806 Compare April 24, 2025 00:51
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 6470700 to 051057d Compare April 24, 2025 00:59
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from ca86806 to aa046e7 Compare April 24, 2025 00:59
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 051057d to f0e31a5 Compare April 24, 2025 04:19
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from aa046e7 to 670ef5d Compare April 24, 2025 04:19
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from f0e31a5 to 8207c6f Compare April 24, 2025 04:29
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 670ef5d to 585a703 Compare April 24, 2025 04:29
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 8207c6f to 67c8514 Compare April 24, 2025 05:07
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 585a703 to 0d4f5a4 Compare April 24, 2025 05:07
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 67c8514 to 4f426fa Compare April 24, 2025 16:54
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 0d4f5a4 to 79ac502 Compare April 24, 2025 16:54
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 4f426fa to 543adf6 Compare April 24, 2025 23:48
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 79ac502 to c55a26f Compare April 24, 2025 23:48
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 543adf6 to 318ce50 Compare April 25, 2025 00:15
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from c55a26f to 6f09232 Compare April 25, 2025 00:15
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 318ce50 to 40306f7 Compare April 25, 2025 00:30
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 6f09232 to 0079d4e Compare April 25, 2025 00:30
@dpeng817 dpeng817 force-pushed the dpeng817/timestamp_event_reporting_override branch from 40306f7 to dc28ff0 Compare April 25, 2025 02:06
@dpeng817 dpeng817 force-pushed the dpeng817/apply_storage_changes_to_airlift branch from 0079d4e to a48ca75 Compare April 25, 2025 02:06
This was referenced Apr 25, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prha prha prha approved these changes

@OwenKephart OwenKephart Awaiting requested review from OwenKephart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpeng817 @prha