Remove unneeded data from playwright test fixture #2341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c00ad25 modified the playwright test data to remove some redundant data, but in the process inadvertently added some additional DB table dumps to the fixture. This regenerates the playwright test fixture with the correct excludes.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2223 modified the
playwright.json.xztest fixture, and inadvertently added some additional DB tables into the test data that do not need to be included. These are mostly just some internal tables that Django/other upstream libraries create and maintain themselves.@naglepuff I missed this in my original review of #2223, I forgot we used the
--excludeflag to ensure certain tables are excluded when runningmanage.py dumpdata. I added some brief documentation on how to generate that data so that we remember next time it needs to be updated.I believe this is also why #2339 is failing CI - the sample data currently includes a
oauth2_provider.Applicationinstance which seems to be causing some issues.