Remove s3 log processing task#2425
Merged
Merged
Conversation
mvandenburgh
added
patch
waxlamp
approved these changes
Jul 2, 2025
jjnesbitt
approved these changes
Jul 2, 2025
Member
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1900
Closes #2074
This was originally implemented as an experiment by @danlamanna, but we ended up taking a different approach outside of dandi-archive and now have https://dandi.github.io/access-page. It has recently been to failing to parse some logs and we've started to get regular Sentry alerts from it. Also, this task runs every hour, adding unnecessary load on the database and requiring a dedicated Celery worker on Heroku.
So in summary, removing this will fix those issues and also save a bit on the Heroku bill (dandi-infra PR).
Note - I've left the associated database models alone for now (i.e. this PR just removes code, it will not have any effect on the database). I'll make a follow up PR after this one where we can discuss removing those/how we want to archive that data.