Skip to content

Remove analytics worker + associated IAM policies#226

Merged
mvandenburgh merged 2 commits into
masterfrom
remove-analytics
Jul 8, 2025
Merged

Remove analytics worker + associated IAM policies#226
mvandenburgh merged 2 commits into
masterfrom
remove-analytics

Conversation

@mvandenburgh

Copy link
Copy Markdown
Member

With dandi/dandi-archive#2425, we no longer need the extra celery worker or extra IAM policies to grant the Heroku user access to the logging bucket.

@mvandenburgh

Copy link
Copy Markdown
Member Author

Setting this to draft, dandi/dandi-archive#2425 must be merged first.

@mvandenburgh
mvandenburgh marked this pull request as draft July 2, 2025 13:35
@mvandenburgh
mvandenburgh marked this pull request as ready for review July 3, 2025 17:58
@mvandenburgh

Copy link
Copy Markdown
Member Author

@jjnesbitt this is ready now, since dandi/dandi-archive#2425 is merged.

Comment thread terraform/modules/dandiset_bucket/log_bucket.tf
}

data "aws_iam_policy_document" "dandiset_log_bucket_policy" {
statement {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry -- just want to make sure we do not remove some used IAM:

I wonder if this is anyhow relates to IAM key/secret for which @satra recently shared with me and @CodyCBakerPhD to setup our processing? is there a way to check if this IAM was used recently?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removing a bucket policy, not an IAM role, so technically there is no concept of "last used". The associated IAM role that the policy is attached to, dandi-api-heroku, is used by the Django app and all the celery workers for AWS access. If it's being used elsewhere, we should phase that out and create a new IAM role/policy for it (I imagine this is not the case though).

@mvandenburgh
mvandenburgh merged commit 161d2a5 into master Jul 8, 2025
2 checks passed
@mvandenburgh
mvandenburgh deleted the remove-analytics branch July 8, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants