Skip to content

CSS overrides for Slovak and Czech#28

Open
procyon99 wants to merge 2 commits into
darktakayanagi:mainfrom
procyon99:main
Open

CSS overrides for Slovak and Czech#28
procyon99 wants to merge 2 commits into
darktakayanagi:mainfrom
procyon99:main

Conversation

@procyon99
Copy link
Copy Markdown

CSS overrides and translation refinements for Slovak and Czech.
Updated steam.json and localization readme.
Since Slovak is not an official Steam language, it might be considered to set its api and/or webapi to Czech to fetch Czech achievement descriptions for supported games.

CSS overrides and translation refinements for Slovak and Czech. 
Updated steam.json and localization readme.
Since Slovak is not an official Steam language, it might be considered to set its api and/or webapi to Czech to fetch Czech achievement descriptions for supported games.
@darktakayanagi
Copy link
Copy Markdown
Owner

@procyon99
Thanks for the translations.
I've committed the updated english file according to the latest version.
could you update you PR to include the translation for the new things that were added?

Comment thread app/locale/steam.json
{ "iso": "ru-RU", "displayName": "Russian", "api": "russian", "webapi": "ru", "native": "Русский" },
{ "iso": "es-ES", "displayName": "Spanish - Spain", "api": "spanish", "webapi": "es", "native": "Español-España" },
{ "iso": "es-419", "displayName": "Spanish - Latin America", "api": "latam", "webapi": "es-419", "native": "Español-Latinoamérica" },
{ "iso": "sk-SK", "displayName": "Slovak", "api": "slovak", "webapi": "sk", "native": "slovenčina" },
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this as is won't work, it will fail when trying to fetch data as this language is not supported officially.
changing the api/webapi to czech might be an option, but I think I need to make some changes on AW's side to support this, (the api serves as the id so having 2 languages with the same api/webapi might break things, like you choose Slovak on the settings but it loads the Czech translation)

@procyon99
Copy link
Copy Markdown
Author

@procyon99 Thanks for the translations. I've committed the updated english file according to the latest version. could you update you PR to include the translation for the new things that were added?

Updated.

UI elements with no translation support remain:

"Checking watchdog status...",
"Watchdog is not running! (overlay/notifications won't trigger)",
"Click to Start Watchdog",
"Watchdog is running (overlay/notifications should work properly)",
"[Hidden description (enable in the settings to show)]",
"Reset playtime and last played",
"Generate achievements.json for Goldberg Emu",
"Open game's icon cache folder",
"Open game's .db cache folder",
Settings - Debug,
Settings - Advanced - Steam Web API key.

Adding translation support for these in the future would make it possible to achieve 100% UI localizations for supported languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants