Skip to content

Skip big-endian floats in test_serialize_scipy_sparse if using scipy>=1.15.0#8977

Merged
phofl merged 2 commits intodask:mainfrom
hendrikmakait:fix-scipy-tests
Jan 7, 2025
Merged

Skip big-endian floats in test_serialize_scipy_sparse if using scipy>=1.15.0#8977
phofl merged 2 commits intodask:mainfrom
hendrikmakait:fix-scipy-tests

Conversation

@hendrikmakait
Copy link
Member

Fixes CI.
Upstream issue: scipy/scipy#22258

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait requested a review from fjetter as a code owner January 6, 2025 14:54
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   11h 30m 11s ⏱️ - 1m 40s
 4 127 tests ±0   4 000 ✅ +4    126 💤 + 14  1 ❌  -  17 
51 714 runs   - 1  49 272 ✅ +3  2 439 💤 +140  3 ❌  - 143 

For more details on these failures, see this check.

Results for commit 2ff8ded. ± Comparison against base commit 40b7646.

This pull request skips 14 tests.
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype1-bsr_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype1-coo_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype1-csc_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype1-csr_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype1-dia_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype1-dok_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype1-lil_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype3-bsr_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype3-coo_matrix]
distributed.protocol.tests.test_scipy ‑ test_serialize_scipy_sparse[dtype3-csc_matrix]
…

@phofl phofl merged commit 94222c0 into dask:main Jan 7, 2025
27 of 31 checks passed
@phofl
Copy link
Collaborator

phofl commented Jan 7, 2025

We might want to remove them altogether depending on the issue, but this seems fine for now

TomAugspurger added a commit to TomAugspurger/distributed that referenced this pull request Feb 3, 2025
Followup to dask#8982 and
dask#8977, where we skipped /
removed tests that were setting the endianness of arrays sent to
scipy.sparse, which isn't supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants