Skip to content

Skip big-endian floats in test_serialize_scipy_sparse if using scipy>=1.15.0 #8977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phofl merged 2 commits into from
Jan 7, 2025
Merged

Skip big-endian floats in test_serialize_scipy_sparse if using scipy>=1.15.0 #8977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa35544
Skip big-endian floats if using scipy>=1.15.0
hendrikmakait Jan 6, 2025
2ff8ded
linting
hendrikmakait Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion distributed/protocol/tests/test_scipy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import pytest
from packaging.version import Version

from distributed.protocol import deserialize, serialize

Expand All @@ -9,6 +10,10 @@
scipy_sparse = pytest.importorskip("scipy.sparse")


SCIPY_VERSION = Version(scipy.__version__)
SCIPY_GE_1_15_0 = SCIPY_VERSION.release >= (1, 15, 0)


@pytest.mark.parametrize(
"sparse_type",
[
Expand All @@ -23,7 +28,22 @@
)
@pytest.mark.parametrize(
"dtype",
[numpy.dtype("<f4"), numpy.dtype(">f4"), numpy.dtype("<f8"), numpy.dtype(">f8")],
[
numpy.dtype("<f4"),
pytest.param(
numpy.dtype(">f4"),
marks=pytest.mark.skipif(
SCIPY_GE_1_15_0, reason="https://github.com/scipy/scipy/issues/22258"
),
),
numpy.dtype("<f8"),
pytest.param(
numpy.dtype(">f8"),
marks=pytest.mark.skipif(
SCIPY_GE_1_15_0, reason="https://github.com/scipy/scipy/issues/22258"
),
),
],
)
def test_serialize_scipy_sparse(sparse_type, dtype):
a = numpy.array([[0, 1, 0], [2, 0, 3], [0, 4, 0]], dtype=dtype)
Expand Down
Loading