Skip to content

Asyncronous notification for mf enforcement rules #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions backend/dataall/modules/metadata_forms/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
from typing import List, Type

from typing import List, Type, Set
import logging
from dataall.base.loader import ModuleInterface, ImportMode

log = logging.getLogger(__name__)


class MetadataFormsApiModuleInterface(ModuleInterface):
"""Implements ModuleInterface for Metadata Forms GraphQl lambda"""
Expand All @@ -19,3 +21,19 @@ def depends_on() -> List[Type['ModuleInterface']]:
from dataall.modules.datasets_base import DatasetBaseApiModuleInterface

return [DatasetBaseApiModuleInterface]


class MetadataFormAsyncHandlersModuleInterface(ModuleInterface):
"""Implements ModuleInterface for metadataform async lambda"""

@staticmethod
def is_supported(modes: Set[ImportMode]):
return ImportMode.HANDLERS in modes

def __init__(self):
import dataall.modules.metadata_forms.handlers
import dataall.modules.metadata_forms.db.metadata_form_models
import dataall.modules.metadata_forms.db.metadata_form_repository
import dataall.modules.metadata_forms.services.metadata_form_enforcement_service

log.info('Metadata Form handlers have been imported')
Original file line number Diff line number Diff line change
Expand Up @@ -391,5 +391,5 @@ def update_version_in_rules(session, uri, version):

@staticmethod
def delete_rule(session, rule_uri):
session.query(MetadataFormEnforcementRule).filter(uri=rule_uri).delete()
session.query(MetadataFormEnforcementRule).filter(MetadataFormEnforcementRule.uri == rule_uri).delete()
session.commit()
3 changes: 3 additions & 0 deletions backend/dataall/modules/metadata_forms/handlers/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from dataall.modules.metadata_forms.handlers import metadata_form_handler

__all__ = ['metadata_form_handler']
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import logging

from dataall.core.tasks.service_handlers import Worker
from dataall.core.tasks.db.task_models import Task
from dataall.modules.metadata_forms.services.metadata_form_enforcement_service import MetadataFormEnforcementService

log = logging.getLogger(__name__)


class EcsMetadataFormHandler:
@staticmethod
@Worker.handler(path='metadata_form.enforcement.notify')
def notify_owners_of_enforcement(engine, task: Task):
with engine.scoped_session() as session:
MetadataFormEnforcementService.notify_owners_of_enforcement(
session=session, rule_uri=task.targetUri, mf_name=task.payload.get('mf_name')
)
Loading
Loading