Skip to content

fix(binder): fix external location table list check end with delimiter '/' #17890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented May 7, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

When creating external location tables, Databend checks list privileges during binding.

AWS S3 Express requires paths to end with a delimiter (/), otherwise it fails:
image

This PR adds a / to the end of check keys, maintaining compatibility with the existing implementation.

Tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label May 7, 2025
@BohuTANG BohuTANG added the ci-cloud Build docker image for cloud test label May 7, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

Docker Image for PR

  • tag: pr-17890-5e70049-1746604766

note: this image tag is only available for internal use.

@BohuTANG
Copy link
Member Author

BohuTANG commented May 7, 2025

This PR waiting for opendal to handle with list local fs file return empty instead of error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant