Skip to content

fix(binder): fix external location table list check end with delimiter '/' #17890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bohutang merged 3 commits into from
May 21, 2025
Merged

fix(binder): fix external location table list check end with delimiter '/' #17890

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09c9169
fix(binder): fix external location table list check end with delimite…
bohutang May 7, 2025
501a6a9
only add the end delimiter for the list
bohutang May 7, 2025
92f4a40
Merge branch 'main' into dev-fix-external-location-end-delimiter
bohutang May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/query/sql/src/planner/binder/ddl/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,10 @@ async fn verify_external_location_privileges(dal: Operator) -> Result<()> {
}

// verify privilege to list
if let Err(e) = dal.list(VERIFICATION_KEY).await {
// Append "/" to the verification key to ensure we are listing the contents of the directory/prefix
// rather than attempting to list a single object.
// Like aws s3 express one, the list requires a end delimiter.
if let Err(e) = dal.list(&format!("{}{}", VERIFICATION_KEY, "/")).await {
errors.push(format!("Permission check for [List] failed: {}", e));
}

Expand Down
Loading