Skip to content

Conversation

@ghanse
Copy link
Contributor

@ghanse ghanse commented Oct 22, 2025

Changes

This PR adds the following row-level checks for geometry columns (e.g. WKT):

  • has_area_less_than
  • has_area_greater_than
  • has_area_equal_to
  • has_area_not_equal_to
  • has_num_points_less_than
  • has_num_points_greater_than
  • has_num_points_equal_to
  • has_num_points_not_equal_to

Linked issues

Resolves #605

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests
  • added performance tests

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

✅ 404/404 passed, 44 skipped, 5h0m33s total

Running from acceptance #3051

@github-actions
Copy link

All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.84%. Comparing base (a06e918) to head (f1d7dcb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   89.77%   89.84%   +0.06%     
==========================================
  Files          56       56              
  Lines        4966     5010      +44     
==========================================
+ Hits         4458     4501      +43     
- Misses        508      509       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Check for complex/large geometries

3 participants