-
Notifications
You must be signed in to change notification settings - Fork 69
Added checks for area and number of points #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
2ccdcdf
dbb8c3f
3820822
4084c5a
4166c44
0fe9c8e
09e2761
74f6a33
c168f50
f42fbb7
87932f3
17fa79b
c5a0d69
825bd68
3850b7d
f1d7dcb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -405,6 +405,54 @@ | |||||||||||||||||||||||||||||
| column: polygon_geom | ||||||||||||||||||||||||||||||
| min_value: 0.0 | ||||||||||||||||||||||||||||||
| max_value: 10.0 | ||||||||||||||||||||||||||||||
| - criticality: error | ||||||||||||||||||||||||||||||
| check: | ||||||||||||||||||||||||||||||
| function: has_area_greater_than | ||||||||||||||||||||||||||||||
| arguments: | ||||||||||||||||||||||||||||||
| column: polygon_geom | ||||||||||||||||||||||||||||||
| limit: 100.0 | ||||||||||||||||||||||||||||||
| - criticality: error | ||||||||||||||||||||||||||||||
| check: | ||||||||||||||||||||||||||||||
| function: has_area_less_than | ||||||||||||||||||||||||||||||
| arguments: | ||||||||||||||||||||||||||||||
| column: polygon_geom | ||||||||||||||||||||||||||||||
| limit: 0.1 | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
| limit: 100.0 | |
| - criticality: error | |
| check: | |
| function: has_area_less_than | |
| arguments: | |
| column: polygon_geom | |
| limit: 0.1 | |
| value: 100.0 | |
| - criticality: error | |
| check: | |
| function: has_area_less_than | |
| arguments: | |
| column: polygon_geom | |
| value: 0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent parameter naming:
has_area_greater_thanandhas_area_less_thanuselimitwhilehas_area_equal_toandhas_area_not_equal_tousevalue. All area functions should use the same parameter name for consistency.