generated from dataforgoodfr/d4g-project-template
-
Notifications
You must be signed in to change notification settings - Fork 9
Kotaemon agnostic base #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on code, fix one kotaemon bug for retrival
merge with main
fraboniface
reviewed
Nov 17, 2025
fraboniface
reviewed
Nov 17, 2025
fraboniface
approved these changes
Nov 18, 2025
Collaborator
fraboniface
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couldn't really test locally because I lack some credentials and GPU support but the changes make sense.
Tests still don't pass but I made some progress:
- Exclude
.ipynbfiles from pre-commit Ruff analysis. The error message is now much more readable and we can see that all errors come from the policy analysis pipeline. - Fixed some errors in kotaemon build (GHA and Dockerfile), but it still fails later in the process. I think it would need its own PR, and anyway we're likely to leave kotaemon altogether, so let's not dwell on this.
This is better than main, so I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean, folder archi, doc:
Fix & improvements :