constants: centralize GLOBAL state support list and use helper in catalog delta (Fixes #601) #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for checking if a connector type supports GLOBAL state. Signed-off-by: Anudhyan Datta <[email protected]>
|
|
Refactor globalStateSupportedConnector check to use constants. Signed-off-by: Anudhyan Datta <[email protected]>
There was a problem hiding this comment.
the PR must be made from staging, not master. Please read the contribution docs at olake.io/docs
| var GlobalStateSupportedDrivers = []DriverType{Postgres, MySQL} | ||
|
|
||
| // IsGlobalStateSupported reports whether the given connector type supports GLOBAL state | ||
| func IsGlobalStateSupported(connectorType string) bool { |
There was a problem hiding this comment.
please remove this function from constants.go. constants.go is static page which should have no computation based methods.
| // TODO: create an array of global state supported connectors in constants | ||
| globalStateSupportedConnector := connectorType == string(constants.Postgres) || connectorType == string(constants.MySQL) | ||
| // flag for connectors which have global state support (centralized in constants) | ||
| globalStateSupportedConnector := constants.IsGlobalStateSupported(connectorType) |
There was a problem hiding this comment.
here you are calling a loop to check the bool. but previously it was a simple OR. this is bit overkill I believe. please do change accordingly. try to use OR itself.
|
hi @Anudhyan , will be closing this pr if you are no longer working on this. |
i am working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
constants: centralize GLOBAL state support list and use helper in catalog delta (Fixes #601)
Description
This PR centralizes the definition of which connectors support GLOBAL state and updates the catalog delta computation to reference that centralized list instead of hard-coding checks.
Changes:
constants.GlobalStateSupportedDrivers: []DriverType{Postgres, MySQL}.constants.IsGlobalStateSupported(connectorType string) bool.types/catalog.goto useconstants.IsGlobalStateSupported(connectorType)in place of the hard-codedPostgres || MySQLcheck in the “GetStreamsDelta” logic.Motivation:
constants.Closes #601.
Type of change
How Has This Been Tested?
go build ./...succeeds (no import changes needed intypes/catalog.go).PostgresORMySQL) now routes throughIsGlobalStateSupported, returning identical results for current connectors.Screenshots or Recordings
N/A
Documentation
Related PRs (If Any)
N/A
Implementation details
constants/constants.go:GlobalStateSupportedDrivers: []DriverType{Postgres, MySQL}IsGlobalStateSupported(connectorType string) booltypes/catalog.go:connectorType == string(constants.Postgres) || connectorType == string(constants.MySQL)constants.IsGlobalStateSupported(connectorType)Backward compatibility
constantsand maintains the same outcomes for existing connectors.