Add missing BMS parameters ❘ Deye 3P#937
Conversation
|
I'll have to think about this one, as I don't necessarily want to create "numbered" entities when there's only one battery. :) |
|
For LV it might look a bit odd when there's only one BMS port. However I'm not really sure what would be a better way to do it. If you have some suggestions, let me know. Personally I think always having numbered is fine. |
3982689 to
8b3c59a
Compare
|
I've discussed this also with Eniris who used the Battery 1 and Battery 2 values. Turned out the Voltage is not published on the Battery 2 register for example on my LV. Don't know how that works for multiple BMS entries, not yet tested. But something to check before going in this direction. Maybe an idea to split off the HV from the LV? |
|
@Bram-Verhagen I believe the LV inverters only have one BMS port, so it would make sense the second one is not returning values. However the BMSes can be daisy chained, so in theory they should be readable in that one port. However aren't multiple batteries always connected in parallel? That means the voltage would always be identical and thus further voltage registers would be unnecessary. There is a lot of differences between LV and HV, so splitting them would be a good idea, but even better would be a code feature to import other definitions to be able to define the common ones only once. Very hard to avoid duplication here. |
Fixes the hardcoded capacity calculation sensor read broken by this change. Signed-off-by: Sopsy <721951+Sopsy@users.noreply.github.com>
This PR adds the following BMS parameters:
And also secondary BMS support (BMS 2) for a second battery, along with Battery 2 (renamed Battery to Battery 1).