Skip to content

Migrate job resource sign 54#383

Merged
adrianburusdbt merged 21 commits intomainfrom
migrate-job-resource-sign-54
Apr 23, 2025
Merged

Migrate job resource sign 54#383
adrianburusdbt merged 21 commits intomainfrom
migrate-job-resource-sign-54

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 9, 2025

Summary: Migrate resource related to job from SDKv2 to Framework.

Changes:

  • Created the model
  • Created the schema
  • Started adding conformance tests
  • Ran make doc to see the changes

Testing:

Checklist:

  • Validate model changes
  • Followed the structure of other existing data sources/ resources
  • Tests pass
  • Manual testing

@ghost ghost marked this pull request as ready for review April 23, 2025 10:49
@ghost ghost self-requested a review as a code owner April 23, 2025 10:49
@ghost ghost requested a review from b-per April 23, 2025 10:50
ExecuteSteps []types.String `tfsdk:"execute_steps"` // exists
DeferringEnvironmentID types.Int64 `tfsdk:"deferring_environment_id"` // exists
Triggers *JobTriggers `tfsdk:"triggers"` // exists
// Settings *JobSettings `tfsdk:"settings"` // has no of threads and target name
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented code still needed?

@adrianburusdbt adrianburusdbt merged commit d9b879e into main Apr 23, 2025
6 checks passed
@adrianburusdbt adrianburusdbt deleted the migrate-job-resource-sign-54 branch April 23, 2025 13:02
adrianburusdbt pushed a commit that referenced this pull request Apr 23, 2025
* Add basic foundation for the migration

* Add basic conformance test

* Add resource model

* Add schema implementation

* Make doc and validate the differences

* Add read resource

* Add delete method

* Add create method

* Add update method

* Add missing code from sdkv2

* Add incremental changes for job tests

* Add schema fixes

* Going over changed code

* Remove call to read method

* Basic tests are passing

* Progress on testing

* Update doc

* Add conformance tests

* Remove from sdk provider

* Add more conformance tests
adrianburusdbt added a commit that referenced this pull request Apr 24, 2025
* Migrate privatelink endpoint data source

* Fix copy paste errors

* Migrate job resource sign 54 (#383)

* Add basic foundation for the migration

* Add basic conformance test

* Add resource model

* Add schema implementation

* Make doc and validate the differences

* Add read resource

* Add delete method

* Add create method

* Add update method

* Add missing code from sdkv2

* Add incremental changes for job tests

* Add schema fixes

* Going over changed code

* Remove call to read method

* Basic tests are passing

* Progress on testing

* Update doc

* Add conformance tests

* Remove from sdk provider

* Add more conformance tests

* Remove legacy handling for databricks connection (#389)

* Remove legacy handling for databricks connection

* Fix tests for databricks credential

---------

Co-authored-by: Vlad Moldoveanu <vlad.moldoveanu@dbtlabs.com>

---------

Co-authored-by: Vlad Moldoveanu <vlad.moldoveanu@dbtlabs.com>
victorasu added a commit that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants