Mark Windows failures as expected fail, and relax runner success criteria#1
Open
lunacd wants to merge 3 commits into
Open
Mark Windows failures as expected fail, and relax runner success criteria#1lunacd wants to merge 3 commits into
lunacd wants to merge 3 commits into
Conversation
Currently xsuccess is treated as a failure. But that will require the tests on all platforms to have exactly the same result, either success or failure. This requirement is looking infeasible for windows, where many expected_fail tests succeed (probably succeeding in unintentional ways) and many expected_succeed tests fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For cps-org#119