DBZ-8564 Move away from dockerhub #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests use testcontainers Docker Compose which results into pulling `docker/compose` image. There doesn't seem to be a way how to force testconatiners to use different registry for this image, the only thing which seems to work is setting up env. variable `TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX`, which would result into pulls from dockerhub when e.g. building it manually wihtout setting this variable, but this is probably not a big issue. At least CI should avoid using dockerhub, as `TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX` is now set in GH actions.
|
@vjuranek Applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests use testcontainers Docker Compose which results into pulling
docker/composeimage. There doesn't seem to be a way how to force testconatiners to use different registry for this image, the only thing which seems to work is setting up env. variableTESTCONTAINERS_HUB_IMAGE_NAME_PREFIX, which would result into pulls from dockerhub when e.g. building it manually wihtout setting this variable, but this is probably not a big issue. At least CI should avoid using dockerhub, asTESTCONTAINERS_HUB_IMAGE_NAME_PREFIXis now set in GH actions.