Fix: When playing start animation with sound and then outcome without sound it was still playing #6477
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QThund
added
1-high
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
… sound it was still playing Audio clip is now null when outcome animation does not have sound.
QThund
force-pushed
the
fix/social-emote-start-sound-keeps-playing-in-outcome
branch
from
05dbd15 to
7dfc809
Compare
dalkia
changed the base branch from
dev
to
fix/concurrency-issue-backpack-avatar
dalkia
changed the base branch from
fix/concurrency-issue-backpack-avatar
to
dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
Audio clip is now null when outcome animation does not have sound.
Test Instructions
Prerrequisites: Needs an emote that plays a sound in the start animation, no sound in one outcome and other sound in other outcome. Ask @QThund for it.
Outcome without sound
Outcome with sound