hotfix: wearable race condition and social emotes fixes #6508
+26
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avatar instantiator
github-actions
bot
requested review from
Ludmilafantaniella,
QThund and
mikhail-dcl
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
davidejensen
changed the title
… sound it was still playing Audio clip is now null when outcome animation does not have sound.
…oteIntent is discarded
davidejensen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
This PR contains 3 fixes for social emotes and a fix that prevents error on backpack and avatar instantiation race condition, specifically it should reduce or entirely avoid the problems we had with avatars being completly broken and stuck.
Test Instructions
Test Steps
Skinning fix
This is the trickest one to reproduce and confirm that is fixed on this PR. The repro steps are
Eventually, skinning should break and avatars should behave strangely like we have been seeing. My recomendation is to try and spend time with the
mainbuild (not the one inprdbut latestmainbranch) and get the error. Its easier to reproduce on low FPS environments, so maybe you can try doing it on the MVMF scenes, with as many as loaded as possible and on higher settings.Once you undertand how its possible to get, come back to this release PR and try again. You should not be able to get it.
Prop flickering (social emote)
Very well described in this PR. Follow the steps
Outcome sound (social emote)
Follow the steps on this PR
Cancellation emote (social emotes)
Follow the steps on this PR
Code Review Reference
Please review our Code Review Standards before submitting.