Skip to content

fix(NQE): WebSocketApi.js send() no-ops on CLOSING/CLOSED #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eordano wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix(NQE): WebSocketApi.js send() no-ops on CLOSING/CLOSED #9418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Explorer/Assets/StreamingAssets/Js/Modules/WebSocketApi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ class WebSocket {
const thisReadyState = this.readyState;
// console.log("WebSocket.send is called", data.constructor.name, `State is ${thisReadyState}`);

// Per the WHATWG WebSocket spec, send() on a CLOSING/CLOSED socket must NOT throw — the data is
// silently discarded. Throwing on CLOSED bubbled out of the scene update loop and was reported to
// Sentry once per tick by misbehaving scenes (UNITY-EXPLORER-NQE: "WebSocket state is 3, cannot
// send data"). Only a still-CONNECTING socket remains an error.
if (thisReadyState === WebSocket.CLOSING || thisReadyState === WebSocket.CLOSED) {
return;
}

if (thisReadyState !== WebSocket.OPEN) {
const errorMessage = `WebSocket state is ${thisReadyState}, cannot send data`;
throw new Error(errorMessage);
Expand Down
Loading