Use synctest instead of fakeclock in tests

[AnomalRoil]

This is a newly added feature of Go 1.25: synctest allows to use the time package like one would in real life, and have a special synctest bubble in which tests are run where synchronization of goroutine can be ensured by calling synctest.Wait() after a time.Sleep() has been called, e.g.

It also will warn about deadlock caused by time.Sleep and such in go routines.

[github-actions]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

[github-actions]

🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer.

[AnomalRoil]

This is weird, I would expect it to pickup my new github workflow file that specifies go 1.25 but it seems it keeps using the old values weirdly.

[pierluca]

Yes, it's designed to use the repo's GitHub actions.
Can you split this PR into one to update the workflows and the other for dkg/synctest ?
It'll be easiest to get this merged.
Had a quick look, LGTM 👍

[jbsv]

go 1.25 and golangci-lint setup are already part of the int32-reviewed branch that should be merged to master soon-ish.

[sonarqubecloud]

Quality Gate failed

Failed conditions
15.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

[jbsv]

Hi @AnomalRoil , is it ok to have a little bit of duplication in test code ? Should we proceed to merge this work within the master branch now ?

[AnomalRoil]

@jbsv IMO yes, and I didn't add duplicate code, it's just I touched existing one and so it triggers SonarCloud analysis on it...

[jbsv]

LGTM