Add protobuf to internal#608
Conversation
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
|
Two questions @jbsv :
|
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
1 similar comment
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
1 similar comment
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
|
1 similar comment
|
d0891ba to
7d486ae
Compare
|
Note that the tests don't pass but it will be fixed in #611. I created an intermediate PR because modifying tests in this PR would be hard to spot since they are all new files |
AnomalRoil
left a comment
AnomalRoil
left a comment
There was a problem hiding this comment.
Just to confirm: this is a plain copy-pasta prior to any changes, right?
Yes! #611 modifies these files as required. The point is that if I introduce these files and modify them, threre's no way to know from the point of view of a reviewer |
2f265e7 to
fab66e0
Compare
|
This PR is being closed because it was cloned in #619 to give it a more explicit name and description |
3 participants
As discussed with @jbsv & @pierluca , the goal is to gradually remove dependency on protobuf. As it is still required for some internal parts, we decided to copy paste the package within the
internalfile to remove its dependency.